Skip to content

Commit

Permalink
use name SimpleConcurrentProcessor
Browse files Browse the repository at this point in the history
  • Loading branch information
cijothomas committed Mar 10, 2025
1 parent 5871538 commit a5ef65d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions opentelemetry-sdk/benches/log_enabled.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
use criterion::{criterion_group, criterion_main, Criterion};
use opentelemetry::logs::{Logger, LoggerProvider};
use opentelemetry_sdk::error::OTelSdkResult;
use opentelemetry_sdk::logs::concurrent_log_processor::ConcurrentExportProcessor;
use opentelemetry_sdk::logs::concurrent_log_processor::SimpleConcurrentProcessor;
use opentelemetry_sdk::logs::{
LogBatch, LogExporter, LogProcessor, SdkLoggerProvider, SimpleLogProcessor,
};
Expand Down Expand Up @@ -60,7 +60,7 @@ where
}

fn criterion_benchmark(c: &mut Criterion) {
let processor = ConcurrentExportProcessor::new(NoopExporter);
let processor = SimpleConcurrentProcessor::new(NoopExporter);
benchmark_exporter_enabled_false(c, "exporter_disabled_concurrent_processor", processor);
let simple = SimpleLogProcessor::new(NoopExporter);
benchmark_exporter_enabled_false(c, "exporter_disabled_simple_processor", simple);
Expand Down
6 changes: 3 additions & 3 deletions opentelemetry-sdk/src/logs/concurrent_log_processor.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ use super::{LogBatch, LogExporter, LogProcessor, SdkLogRecord};
/// This is intended to be used when exporting to operating system
/// tracing facilities like Windows ETW, Linux TracePoints etc.
#[derive(Debug)]
pub struct ConcurrentExportProcessor<T: LogExporter> {
pub struct SimpleConcurrentProcessor<T: LogExporter> {
exporter: T,
}

impl<T: LogExporter> ConcurrentExportProcessor<T> {
impl<T: LogExporter> SimpleConcurrentProcessor<T> {
/// Creates a new `ConcurrentExportProcessor` with the given exporter.
pub fn new(exporter: T) -> Self {
Self { exporter }
}

Check warning on line 24 in opentelemetry-sdk/src/logs/concurrent_log_processor.rs

View check run for this annotation

Codecov / codecov/patch

opentelemetry-sdk/src/logs/concurrent_log_processor.rs#L22-L24

Added lines #L22 - L24 were not covered by tests
}

impl<T: LogExporter> LogProcessor for ConcurrentExportProcessor<T> {
impl<T: LogExporter> LogProcessor for SimpleConcurrentProcessor<T> {
fn emit(&self, record: &mut SdkLogRecord, instrumentation: &InstrumentationScope) {
let log_tuple = &[(record as &SdkLogRecord, instrumentation)];
let _ = futures_executor::block_on(self.exporter.export(LogBatch::new(log_tuple)));
Expand Down
4 changes: 2 additions & 2 deletions stress/src/logs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
*/
use opentelemetry_appender_tracing::layer;
use opentelemetry_sdk::error::OTelSdkResult;
use opentelemetry_sdk::logs::concurrent_log_processor::ConcurrentExportProcessor;
use opentelemetry_sdk::logs::concurrent_log_processor::SimpleConcurrentProcessor;
use opentelemetry_sdk::logs::SdkLoggerProvider;
use opentelemetry_sdk::logs::{LogBatch, LogExporter};

Expand Down Expand Up @@ -65,7 +65,7 @@ fn main() {

// LoggerProvider with a no-op processor.
let provider: SdkLoggerProvider = SdkLoggerProvider::builder()
.with_log_processor(ConcurrentExportProcessor::new(NoopExporter::new(enabled)))
.with_log_processor(SimpleConcurrentProcessor::new(NoopExporter::new(enabled)))
.build();

// Use the OpenTelemetryTracingBridge to test the throughput of the appender-tracing.
Expand Down

0 comments on commit a5ef65d

Please sign in to comment.