Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use static dispatch in SimpleLogProcessor #2338

Merged

Conversation

cijothomas
Copy link
Member

Part of #1942
Given this is a breaking change, we should not merge until 0.27.1 is out.

Thanks @lalitb for helping with this. I will see if I can continue this to achieve the rest of ideas mentioned in 1942 and avoid dyn dispatch completely in Log hot path (not for Batch scenario+any custom)

@cijothomas cijothomas requested a review from a team as a code owner November 25, 2024 19:45
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (a3c469b) to head (4c24d47).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_processor.rs 83.3% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2338   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        123     123           
  Lines      21492   21492           
=====================================
  Hits       17096   17096           
  Misses      4396    4396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 6b71301 into open-telemetry:main Dec 2, 2024
21 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/simplelog-static branch December 2, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants