-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add Scope attributes test cases for metrics #2736
test: Add Scope attributes test cases for metrics #2736
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2736 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 123 123
Lines 22736 22770 +34
=====================================
+ Hits 18058 18093 +35
+ Misses 4678 4677 -1 ☔ View full report in Codecov by Sentry. |
InstrumentationScope ignores the order of attributes, so they are identical. Signed-off-by: Shunpoco <[email protected]>
This test checks if meter_provider provides different meters when each call has different scope attributes. Signed-off-by: Shunpoco <[email protected]>
Signed-off-by: Shunpoco <[email protected]>
ba1afd0
to
b051d15
Compare
Not likely to change as it is not required. For Metrics this is important to get pre-aggregation correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes #2702
Changes
Add additional unit test to cover Scope attributes for metrics.
I don't add any test cases for Logger/Tracer because their with_scope() method creates new Logger/Tracer regardless of Scope attribute's identity (Will we change the methods in the future?).
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes