Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add benchmark tests for baggage #2737

Merged
merged 1 commit into from
Mar 2, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Mar 2, 2025

Relates to #2717 point 2

Changes

  • I was not sure about the MAX_KEY_VALUE_PAIRS const, it is currently private so I just duplicated it for the benchmark test. let me know, if you want to make it public or not.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner March 2, 2025 18:00
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (13fafcb) to head (d6deed3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2737   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        123     123           
  Lines      22770   22770           
=====================================
  Hits       18092   18092           
  Misses      4678    4678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gruebel
Copy link
Member Author

gruebel commented Mar 2, 2025

@cijothomas could you add the performance label to validate the benchmark works in CI as expected.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Let us also add some measuring the cost of adding Baggage to Context. It might be required to make Baggage a top-level entry in Context instead of storing it inside Context's hash map to gain perf.

@cijothomas cijothomas merged commit 92303b6 into open-telemetry:main Mar 2, 2025
23 checks passed
@cijothomas
Copy link
Member

@cijothomas could you add the performance label to validate the benchmark works in CI as expected.

oops sorry missed this. We can run targeted benches locally for now. The CI runs entire set, which is quite expensive, and not sure if that is something CNCF encourages us to do...

@gruebel gruebel deleted the add-baggage-bench branch March 2, 2025 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants