doc: on how to set right cardinality limit #2998
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2998 +/- ##
=====================================
Coverage 81.1% 81.1%
=====================================
Files 126 126
Lines 24794 24794
=====================================
Hits 20131 20131
Misses 4663 4663 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cijothomas
changed the title
utpilla
reviewed
May 23, 2025
utpilla
reviewed
May 23, 2025
utpilla
reviewed
May 23, 2025
| the cardinality limit to 1,000. Delta temporality allows the SDK to reset | ||
| after each export, accommodating different attribute combinations across | ||
| intervals without accumulating state. | ||
| * **Example 2:** For web applications with known Request Per Second (RPS) rates, |
There was a problem hiding this comment.
I have some concerns about using this example. It might be confusing to people who rely on metrics to calculate RPS in the first place.
utpilla
reviewed
May 23, 2025
| above), use the same calculation approach as cumulative temporality. | ||
| * For dynamic scenarios where not all combinations appear in every export cycle, | ||
| base the limit on expected total measurements within a single interval. | ||
| * **Example 1:** If your application generates at most 1,000 distinct attribute |
There was a problem hiding this comment.
How about putting the examples along with their respective scenarios?
- When all possible attribute combinations are known... Use Example1 here
- For dynamic scenarios where not all combinations appear in every export cycle, ... Use Example 2 here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall doc is still WIP, but adding some more useful information about setting right cardinality limit.