Skip to content

fix: use default endpoint for endpoint when provided empty string #3000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joonas
Copy link

@joonas joonas commented May 23, 2025

Changes

According to the WithExporterConfig docs, passing an empty string towith_endpoint should result in the default endpoint being used, however that's not currently what happens.

This change adds an additional check to make sure that the provided endpoint is not an empty string, and if it is, then it'll fall back to using the default endpoint instead.

As an aside, I considered changing the WithExportConfig implementation of with_endpoint to do this check, and if that's the preferred route to go, I'm happy to switch these changes over to there instead.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@joonas joonas requested a review from a team as a code owner May 23, 2025 16:47
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.2%. Comparing base (200885a) to head (3ecf829).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3000   +/-   ##
=====================================
  Coverage   81.2%   81.2%           
=====================================
  Files        126     126           
  Lines      24839   24855   +16     
=====================================
+ Hits       20173   20189   +16     
  Misses      4666    4666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant