fix: use default endpoint for endpoint when provided empty string #3000
+22
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
According to the
WithExporterConfig
docs, passing an empty string towith_endpoint
should result in the default endpoint being used, however that's not currently what happens.This change adds an additional check to make sure that the provided endpoint is not an empty string, and if it is, then it'll fall back to using the default endpoint instead.
As an aside, I considered changing the
WithExportConfig
implementation ofwith_endpoint
to do this check, and if that's the preferred route to go, I'm happy to switch these changes over to there instead.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes