Skip to content

refactor: remove dropped_attribute_counts from API #3005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mohammadVatandoost
Copy link
Contributor

For #2752

@mohammadVatandoost mohammadVatandoost requested a review from a team as a code owner May 24, 2025 15:19
@mohammadVatandoost mohammadVatandoost changed the title remove dropped_attribute_counts from API refactor: remove dropped_attribute_counts from API May 24, 2025
Copy link

codecov bot commented May 24, 2025

Codecov Report

Attention: Patch coverage is 9.80392% with 92 lines in your changes missing coverage. Please review.

Project coverage is 80.8%. Comparing base (8882c31) to head (1560773).

Files with missing lines Patch % Lines
opentelemetry-proto/src/transform/tracez.rs 0.0% 72 Missing ⚠️
opentelemetry-proto/src/transform/trace.rs 23.0% 20 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3005     +/-   ##
=======================================
- Coverage   81.0%   80.8%   -0.3%     
=======================================
  Files        126     126             
  Lines      24753   24794     +41     
=======================================
- Hits       20070   20042     -28     
- Misses      4683    4752     +69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

span_id: link.span_context.span_id().to_bytes().to_vec(),
trace_state: link.span_context.trace_state().header(),
attributes: Attributes::from(link.attributes).0,
dropped_attributes_count: source_span.dropped_attributes_count,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really correct? The dropped_attributes_count on the source span is for the span, and not this link, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants