refactor: remove dropped_attribute_counts from API #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadVatandoost
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3005 +/- ##
=======================================
- Coverage 81.0% 80.8% -0.3%
=======================================
Files 126 126
Lines 24753 24794 +41
=======================================
- Hits 20070 20042 -28
- Misses 4683 4752 +69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bantonsson
reviewed
May 26, 2025
| span_id: link.span_context.span_id().to_bytes().to_vec(), | ||
| trace_state: link.span_context.trace_state().header(), | ||
| attributes: Attributes::from(link.attributes).0, | ||
| dropped_attributes_count: source_span.dropped_attributes_count, |
There was a problem hiding this comment.
Is this really correct? The dropped_attributes_count on the source span is for the span, and not this link, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #2752