update file-based configuration to allow for multiple inputs #4151
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file-configuration examples suggest that it should be possible to parse multiple configuration files:
The
OTEL_EXPERIMENTAL_CONFIG_FILE
and relatedconfiguration.parse
method don't allow for multiple inputs, so I propose to adjust the descriptions of these to allow for multiple inputs.Also, in PHP SIG's implementation, when we
parse
config, we also apply default values which makes "custom merging" quite difficult, whereas merging the YAML inputs is straightforward. So, I've also proposed that multiple config inputs should be merged prior to parsing.This is related to open-telemetry/opentelemetry-configuration#102 where I want to apply a custom sampler to a file-based config without breaking other SIGs by providing config they cannot parse.
For non-trivial changes, follow the change proposal process.
CHANGELOG.md
file updated for non-trivial changesspec-compliance-matrix.md
updated if necessary