Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update file-based configuration to allow for multiple inputs #4151

Closed
wants to merge 1 commit into from

Conversation

brettmc
Copy link
Contributor

@brettmc brettmc commented Jul 17, 2024

The file-configuration examples suggest that it should be possible to parse multiple configuration files:

A more complex case might consist of parsing multiple configuration files from different sources, merging them using custom logic, and creating SDK components from the merged configuration model

The OTEL_EXPERIMENTAL_CONFIG_FILE and related configuration.parse method don't allow for multiple inputs, so I propose to adjust the descriptions of these to allow for multiple inputs.

Also, in PHP SIG's implementation, when we parse config, we also apply default values which makes "custom merging" quite difficult, whereas merging the YAML inputs is straightforward. So, I've also proposed that multiple config inputs should be merged prior to parsing.

This is related to open-telemetry/opentelemetry-configuration#102 where I want to apply a custom sampler to a file-based config without breaking other SIGs by providing config they cannot parse.

For non-trivial changes, follow the change proposal process.

@brettmc brettmc requested review from a team July 17, 2024 00:14
@arminru arminru added the area:configuration Related to configuring the SDK label Jul 23, 2024
@arminru
Copy link
Member

arminru commented Jul 23, 2024

cc @open-telemetry/configuration-maintainers

Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 31, 2024
Copy link

github-actions bot commented Aug 7, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:configuration Related to configuring the SDK Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants