Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the missing parent span #6164

Closed
wants to merge 1 commit into from
Closed

Conversation

theptrk
Copy link

@theptrk theptrk commented Feb 1, 2025

Why

The parent span is missing in the examples for the Flask example

  • this means the child span has a NULL parent_id

What

I match the name of the parent span with the docs here: https://opentelemetry.io/docs/languages/python/getting-started/

Screenshot 2025-01-31 at 4 53 59 PM Screenshot 2025-01-31 at 4 51 59 PM

@theptrk theptrk requested a review from a team as a code owner February 1, 2025 00:54
Copy link

CLA Not Signed

@opentelemetrybot opentelemetrybot requested a review from a team February 1, 2025 00:54
@tiffany76
Copy link
Contributor

Thanks, @theptrk! Before we review, could you sign the CLA?

@xrmx
Copy link
Contributor

xrmx commented Feb 6, 2025

@theptrk Please retry with 1.30.0, 1.29.0 has a spurious wrapper span for flask debug server.

@tiffany76
Copy link
Contributor

@theptrk, hopefully the version update solved your problem. I'm going to close this PR for now, but please raise an issue if you're still having trouble. Thanks!

@tiffany76 tiffany76 closed this Feb 20, 2025
@theptrk
Copy link
Author

theptrk commented Feb 21, 2025

Thanks for the updates. I had delays figuring out the license with my work policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants