-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve pipeline section docs #6176
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Left one comment, I am not a technical writer so it may be that others have a better suggestion here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beyond the suggested change from @mx-psi this looks good to me. If you can fix that, we can merge it in
@@ -627,6 +627,24 @@ service: | |||
processors: [batch, memory_limiter] | |||
exporters: [opencensus, zipkin] | |||
``` | |||
As with components, use the `type[/name]` syntax to create additional pipelines for a given type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with components, use the `type[/name]` syntax to create additional pipelines for a given type. | |
As with components, use the `type[/name]` syntax to create additional pipelines for a given type. Here is an example extending the previous configuration: |
```yaml | ||
service: | ||
pipelines: | ||
metrics: | ||
receivers: [opencensus, prometheus] | ||
processors: [batch] | ||
exporters: [opencensus, prometheus] | ||
traces: | ||
receivers: [opencensus, jaeger] | ||
processors: [batch, memory_limiter] | ||
exporters: [opencensus, zipkin] | ||
traces/better_pipeline: | ||
receivers: [opencensus] | ||
processors: [batch] | ||
exporters: [zipkin] | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this so that we can keep the focus on what was added?
```yaml | |
service: | |
pipelines: | |
metrics: | |
receivers: [opencensus, prometheus] | |
processors: [batch] | |
exporters: [opencensus, prometheus] | |
traces: | |
receivers: [opencensus, jaeger] | |
processors: [batch, memory_limiter] | |
exporters: [opencensus, zipkin] | |
traces/better_pipeline: | |
receivers: [opencensus] | |
processors: [batch] | |
exporters: [zipkin] | |
``` | |
```yaml | |
service: | |
pipelines: | |
# ... | |
traces: | |
# ... | |
traces/better_pipeline: | |
receivers: [opencensus] | |
processors: [batch] | |
exporters: [zipkin] | |
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is there an alternative name to /better_pipeline
that we can use? Previous examples in the page use /2
.
Hi @PadreSVK, please take a look at the most recent suggested changes so we can move this PR forward. Thanks! |
based on information provided: