Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[i18n] Add page-not-yet-translated banner, ask for help #6287

Merged
merged 1 commit into from
Feb 11, 2025
Merged

[i18n] Add page-not-yet-translated banner, ask for help #6287

merged 1 commit into from
Feb 11, 2025

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 11, 2025 •
edited
Loading

  • Contributes to Improved i18n support #4467
  • Adds a banner at the top of fallback pages, informing readers of the obvious (that the page is in English), explaining why (page hasn't been translated), and asks for help.

Preview

Screenshot

image

@chalin chalin added the i18n internationalization label Feb 11, 2025
@chalin chalin requested a review from a team as a code owner February 11, 2025 13:45
@chalin
Copy link
Contributor Author

chalin commented Feb 11, 2025

My plan is to localize the text of the banner, but I wanted to get this submitted as a first version.

@chalin chalin mentioned this pull request Feb 11, 2025
Open
7 tasks
@chalin
Copy link
Contributor Author

chalin commented Feb 11, 2025

Tracker:

@chalin chalin merged commit abe2eb5 into open-telemetry:main Feb 11, 2025
18 checks passed
@chalin chalin deleted the chalin-im-fallback-banner-2025-02-11 branch February 11, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svrnm svrnm svrnm approved these changes

Assignees
No one assigned
Labels
i18n internationalization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @svrnm