Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http port on internal telemetry page #6314

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Fix http port on internal telemetry page #6314

merged 1 commit into from
Feb 21, 2025

Conversation

tiffany76
Copy link
Contributor

Fixes #6304

@tiffany76 tiffany76 requested a review from a team as a code owner February 14, 2025 01:02
@opentelemetrybot opentelemetrybot requested review from a team and evan-bradley and removed request for a team February 14, 2025 01:02
chalin
chalin approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Still need SIG approval.

@chalin chalin added the sig-approval-missing Co-owning SIG didn't provide an approval label Feb 14, 2025
@tiffany76
Copy link
Contributor Author

@open-telemetry/collector-approvers, PTAL. Thanks!

@cartermp cartermp added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit ee990f9 Feb 21, 2025
20 checks passed
@cartermp cartermp deleted the tiffany76-patch-1 branch February 21, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@cartermp cartermp cartermp approved these changes

@songy23 songy23 songy23 approved these changes

@evan-bradley evan-bradley Awaiting requested review from evan-bradley evan-bradley was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
sig:collector sig-approval-missing Co-owning SIG didn't provide an approval
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

collector: Internal telemetry
4 participants
@tiffany76 @chalin @cartermp @songy23