Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Convert keep-up-to-date.md to an include #6383

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 19, 2025

Previews:

The only files with meaningful changes are those that include content/en/docs/languages/js/_browser-instrumentation-warning.md (the pages under /js/) and this is because of our switch from alert-md to the alert shortcode:

$ (cd public && git diff -bw --ignore-blank-lines -I "’|'" -I 'modified_time|dateModified|Last modified') | grep ^diff | grep -Ev '/(es|fr|ja|pt|zh)/' | grep -v sitemap
diff --git a/docs/languages/js/getting-started/browser/index.html b/docs/languages/js/getting-started/browser/index.html
diff --git a/docs/languages/js/index.html b/docs/languages/js/index.html
diff --git a/docs/languages/js/instrumentation/index.html b/docs/languages/js/instrumentation/index.html
diff --git a/site/index.html b/site/index.html

@chalin chalin added enhancement New feature or request i18n internationalization labels Feb 19, 2025
@chalin chalin requested a review from a team as a code owner February 19, 2025 18:52
@opentelemetrybot opentelemetrybot requested review from a team February 19, 2025 18:53
@chalin chalin marked this pull request as draft February 19, 2025 18:55
@chalin chalin marked this pull request as ready for review February 19, 2025 18:58
@@ -74,4 +74,4 @@ observabilidade aos usuários finais, consulte

[envie um PR]: /docs/contributing/pull-requests/

{{% ecosystem/keep-up-to-date integration %}}
{{% include keep-up-to-date.md integration %}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@open-telemetry/docs-pt-approvers @vitorvasc - I'll let you update the included word (here and in the other pt pages) name when you localize keep-up-to-date.md.

Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin force-pushed the chalin-im-include-feature-rework-2025-02-19 branch from e862d89 to 126148d Compare February 19, 2025 23:53
@opentelemetrybot opentelemetrybot requested a review from a team February 19, 2025 23:55
@chalin chalin merged commit b6ddba1 into open-telemetry:main Feb 20, 2025
18 checks passed
@chalin chalin deleted the chalin-im-include-feature-rework-2025-02-19 branch February 20, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request i18n internationalization lang:pt sig:javascript
Projects
Development

Successfully merging this pull request may close these issues.

[i18n] Rework shortcodes/ecosystem/keep-up-to-date.md for better localization support
2 participants