[database-Loan] DBflow to Room migration

[itsPronay]

PART OF - https://mifosforge.jira.com/browse/MIFOSAC-333

Please make sure these boxes are checked before submitting your pull request - thanks!

• Run the static analysis check ./gradlew check or ci-prepush.sh to make sure you didn't break anything

• If you have multiple commits please combine them into one commit by squashing them.

[HekmatullahAmin]

@itsPronay I noticed that some data classes inherit from MifosBaseModel, which overrides toString(). If this is only for debugging purposes, I don’t think we really need it. It would be good to check with @therajanmaurya Sir since he created the class.

If he agrees to remove it, then remove it from all data classes in the database module and delete MifosBaseModel itself. This will help clean up unnecessary inheritance and keep the models lightweight.

[itsPronay]

@itsPronay I noticed that some data classes inherit from MifosBaseModel, which overrides toString(). If this is only for debugging purposes, I don’t think we really need it. It would be good to check with @therajanmaurya Sir since he created the class.

If he agrees to remove it, then remove it from all data classes in the database module and delete MifosBaseModel itself. This will help clean up unnecessary inheritance and keep the models lightweight.

@HekmatullahAmin you are viewing the old code, which was for dbflow. News codes are in room package and all the entities were migrated by @Darkeye14 already.

In room package some data classes still use 'columnInfo' because that's not the part of the loan. Since this PR was about loan's migration i have only implemented that in loan entities.

[HekmatullahAmin]

@HekmatullahAmin you are viewing the old code, which was for dbflow. News codes are in room package and all the entities were migrated by @Darkeye14 already.

In room package some data classes still use 'columnInfo' because that's not the part of the loan. Since this PR was about loan's migration i have only implemented that in loan entities.

Got it @itsPronay ! It seems like the database module need a cleanup. Since I wasn’t working on the Android client, I wasn’t aware of the old and new code separation. Just out of curiosity—why are we still keeping the old DBFlow-related code? Could it be deleted, or did you leave it because it was out of the scope of your assigned task?

Also, @therajanmaurya Sir, it looks fine to me. You can have your final look and review.

[itsPronay]

@he

@HekmatullahAmin you are viewing the old code, which was for dbflow. News codes are in room package and all the entities were migrated by @Darkeye14 already.
In room package some data classes still use 'columnInfo' because that's not the part of the loan. Since this PR was about loan's migration i have only implemented that in loan entities.

Got it @itsPronay ! It seems like the database module need a cleanup. Since I wasn’t working on the Android client, I wasn’t aware of the old and new code separation. Just out of curiosity—why are we still keeping the old DBFlow-related code? Could it be deleted, or did you leave it because it was out of the scope of your assigned task?

Also, @therajanmaurya Sir, it looks fine to me. You can have your final look and review.

@HekmatullahAmin, previously @Darkeye14 was working on this. When I took over, he asked me to keep the old code , probably because bhaiya told him to do so or just to ensure we didn’t break anything and could do a recheck