Home Fragment, Transfer Fragment, Profile Fragment and Account Fragment #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abhijitramesh @therajanmaurya @edcable Please review it |
garvit984
changed the title
|
hello @garvit984, as much as I appreciate your humongous contribution, I feel very sorry to tell you that the Issues that you have fixed, have already been fixed in #115, #112, #117, #118 and await a review from the senior project maintainers. It is always advised to not create a duplicate PR hence until any already existing PR for these issues are closed, we cannot consider this PR and so I will have to close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102 #103 #105 #107
Basic UI design of Home fragment, Profile Fragment and Account Fragment designed during GCI is implemented.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.