Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui update of homescreen #90

Closed
wants to merge 1 commit into from

Conversation

PiyushSharma99
Copy link
Contributor

@PiyushSharma99 PiyushSharma99 commented Dec 9, 2019

Fixes #89

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@PiyushSharma99
Copy link
Contributor Author

@GOVINDDIXIT @jddeep @santoshconflux Please review and approve. Thanks

Copy link

@jddeep jddeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@GOVINDDIXIT GOVINDDIXIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Copy link

@harshshinde07 harshshinde07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!
But can you try to make the view a bit more uniform? You can check the mifos-mobile app for some inspiration.
Thanks :)

@sabya48
Copy link

sabya48 commented Mar 26, 2020

@harshshinde07 can i work on this please to make it more better

@harshshinde07
Copy link

Hi @sabya48 , the issue was created as a part of GCI for the students and the whole app needs redesign. So idk if it needs to be given more attention. @luckyman20 please look into it

@luckyman20
Copy link
Collaborator

Please refer #118

@luckyman20 luckyman20 closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the UI of the homescreen
6 participants