Feat: [:core:network] - Migrated to KMP #2739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@niyajali brother I have migrated the network module to KMP. This module depends on the datastore module for token. Once the datastore module is successfully migrated, I will pull those changes and integrate them. Meanwhile, let me know if there are any changes that need to be made to these files. |
niyajali
requested changes
Jan 12, 2025
.../network/src/commonMain/kotlin/org/mifos/mobile/core/network/services/ClientChargeService.kt
Outdated
Show resolved
Hide resolved
Nagarjuna0033
force-pushed
the
migrating-network-module-to-kmp
branch
from
05fa3d5 to
405e7a0
Compare
niyajali
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#111
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.