fix: UriTemplate Error

src/classes/field.js

@@ -1,4 +1,3 @@
-const UriTemplate = require('uritemplate');
 const DataModelHelper = require('../helpers/data-model');
 const PropertyHelper = require('../helpers/property');
 
@@ -162,15 +161,7 @@ const Field = class {
         if (!isEnum) {
           // Is this a URL template?
           // This processes most strings... so could be a bit intensive
-          const template = UriTemplate.parse(data);
-          let isUrlTemplate = false;
-          for (const expression of template.expressions) {
-            if (expression.constructor.name === 'VariableExpression') {
-              isUrlTemplate = true;
-              break;
-            }
-          }
-          if (isUrlTemplate) {
+          if (PropertyHelper.isUrlTemplate(data)) {
             returnType = 'https://schema.org/Text';
           } else if (this.constructor.URL_REGEX.test(data)) {
             returnType = 'https://schema.org/URL';

src/helpers/property-spec.js

@@ -0,0 +1,18 @@
+const PropertyHelper = require('./property');
+
+describe('PropertyHelper', () => {
+  describe('isUrlTemplate', () => {
+    it('should return true for template', async () => {
+      const result = PropertyHelper.isUrlTemplate('{test}');
+      expect(result).toBe(true);
+    });
+    it('should return false for string', async () => {
+      const result = PropertyHelper.isUrlTemplate('test');
+      expect(result).toBe(false);
+    });
+    it('should return false for erroneous string', async () => {
+      const result = PropertyHelper.isUrlTemplate('{description}{something-else}.');
+      expect(result).toBe(false);
+    });
+  });
+});

src/helpers/property.js

@@ -1,4 +1,5 @@
 const crypto = require('crypto');
+const UriTemplate = require('uritemplate');
 const DataModelHelper = require('./data-model');
 
 const PropertyHelper = class {
@@ -183,6 +184,20 @@ const PropertyHelper = class {
     return keyChecks;
   }
 
+  static isUrlTemplate(data) {
+    try {
+      const template = UriTemplate.parse(data);
+      for (const expression of template.expressions) {
+        if (expression.constructor.name === 'VariableExpression') {
+          return true;
+        }
+      }
+    } catch (e) {
+      return false;
+    }
+    return false;
+  }
+
   static clearCache() {
     this.enumCache = {};
     this.propertyCache = {};