Skip to content

Commit

Permalink
remove old comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lukehesluke committed Jan 30, 2025
1 parent 4e56d61 commit 831b44e
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
2 changes: 0 additions & 2 deletions src/feed-context-utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
* @typedef {import('./models/FeedContext').FeedContext} FeedContext
*/

/* TODO[suggestion] put FeedContext into a class so that it controls access to itself? And so that all it's logic
(e.g. progressbar updating stuff) can be in one place? */
/**
* @param {string} baseUrl
* @returns {FeedContext}
Expand Down
6 changes: 0 additions & 6 deletions src/harvest-rpde.js
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ async function baseHarvestRPDE({
const pageDescriptiveIdentifier = (url, thisHeaders) => `RPDE feed ${feedContextIdentifier} page "${url}" (request headers: ${JSON.stringify(thisHeaders)})`;
let isInitialHarvestComplete = false;
let numberOfRetries = 0;
// TODO2 make context something that is only internal to this lib. And it
// shouldn't take multibar. It can be exposed to the client via the callbacks,
// but the client and lib should not be expected to both mutate this object!
const context = overrideContext || createFeedContext(baseUrl);

let url = baseUrl;
Expand All @@ -59,9 +56,6 @@ async function baseHarvestRPDE({
// Harvest forever, until a 404 is encountered
for (; ;) {
if (optionallyWaitBeforeNextRequest) await optionallyWaitBeforeNextRequest();
// TODO3 put in broker
// // If harvesting is paused, block using the mute
// if (pauseResume) await pauseResume.waitIfPaused();

const headersForThisRequest = await headers();

Expand Down

0 comments on commit 831b44e

Please sign in to comment.