Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Decouple Harvesting-Utils from Broker Microservice #18

Merged
merged 13 commits into from
Jan 30, 2025
Merged

chore: Decouple Harvesting-Utils from Broker Microservice #18

merged 13 commits into from
Jan 30, 2025

Conversation

lukehesluke
Copy link
Contributor

Closes #9

QA

  1. Broker still works (see this PR: chore(broker): De-couple with harvesting-utils openactive-test-suite#707)
  2. The example script also still works

Screenshot 2025-01-30 at 20 20 54

lukehesluke
lukehesluke commented Jan 30, 2025
View reviewed changes
README.md
@@ -33,60 +33,9 @@ Indefinitely harvests an RPDE feed, following the ["expected consumer behaviour"

**N.B.** This function will run indefinitely, and only return if a fatal error occurs. For this reason, you will generally **not** want to run `await harvestRPDE(..)`.

#### Required Parameters
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a hassle to keep these up-to-date alongside the type definitions and JSDocs. These should either not exist or be auto-generated.

lukehesluke
lukehesluke commented Jan 30, 2025
View reviewed changes
package.json
@@ -5,7 +5,8 @@
"main": "index.js",
"types": "built-types/index.d.ts",
"scripts": {
"test": "eslint && tsc",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint wasn't doing anything before

@lukehesluke lukehesluke marked this pull request as ready for review January 30, 2025 20:28
@nickevansuk nickevansuk merged commit b7ed519 into master Jan 30, 2025
1 check passed
@nickevansuk nickevansuk deleted the feature/decouple branch January 30, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickevansuk nickevansuk nickevansuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Decouple Harvesting Utils from Broker Microservice
2 participants
@lukehesluke @nickevansuk