Skip to content

Fix #131 Human in the Loop MCP approval fails #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

Fix #131 Human in the Loop MCP approval fails #156

merged 2 commits into from
Jul 10, 2025

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 25, 2025

This pull request resolves #131

@seratch seratch requested a review from dkundel-openai June 25, 2025 09:47
@seratch seratch self-assigned this Jun 25, 2025
@seratch seratch added bug Something isn't working package:agents-core labels Jun 25, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0446650

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@seratch seratch mentioned this pull request Jun 25, 2025
Closed
dkundel-openai
dkundel-openai approved these changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator

@dkundel-openai dkundel-openai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a changeset? Looks good otherwise

@dkundel-openai
Copy link
Collaborator

Do we need to make the field optional for backwards compatibility?

@seratch
Copy link
Member Author

seratch commented Jul 7, 2025

Do we need to make the field optional for backwards compatibility?

Good point; I will make it optional for now, but probably we can make it non-optional in future minor/major release. Will add TODO comment for it too

@seratch seratch force-pushed the issue-131-mcp-approval branch from 1e888cd to 0446650 Compare July 10, 2025 09:25
@seratch
Copy link
Member Author

seratch commented Jul 10, 2025

I will make it optional for now, but probably we can make it non-optional in future minor/major release. Will add TODO comment for it too

This is done

@seratch seratch merged commit 361f6de into main Jul 10, 2025
5 checks passed
@seratch seratch deleted the issue-131-mcp-approval branch July 10, 2025 09:28
@seratch
Copy link
Member Author

seratch commented Jul 10, 2025

Ah this one didn't have changeset; I will add it later

seratch added a commit that referenced this pull request Jul 11, 2025
@seratch
Add changeset file for #156
d553748
@seratch seratch mentioned this pull request Jul 11, 2025
Merged
seratch added a commit that referenced this pull request Jul 11, 2025
@seratch
Add changeset file for #156 (#198)
a60eabe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkundel-openai dkundel-openai dkundel-openai approved these changes

Assignees

@seratch seratch

Labels
bug Something isn't working package:agents-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Human in the Loop MCP approval fails
2 participants
@seratch @dkundel-openai