[1/n] Add MCP types to the SDK #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2025
Merged
rm-openai
added a commit
that referenced
this pull request
Mar 25, 2025
| from .server import MCPServer | ||
|
|
||
|
|
||
| class MCPUtil: |
There was a problem hiding this comment.
this is the same as the other MCPUtil class
There was a problem hiding this comment.
Yeah sorry deleted in the end of stack.
Comment on lines
+37
to
+45
| @abc.abstractmethod | ||
| async def list_tools(self) -> list[MCPTool]: | ||
| """List the tools available on the server.""" | ||
| pass | ||
|
|
||
| @abc.abstractmethod | ||
| async def call_tool(self, tool_name: str, arguments: dict[str, Any] | None) -> CallToolResult: | ||
| """Invoke a tool on the server.""" | ||
| pass |
There was a problem hiding this comment.
what do you think about making these just return our Tool class? ie. the MCPServer is responsible for doing the conversion
this is an MCPServer class specifically for integrating with our SDK, so it can use our types
There was a problem hiding this comment.
Yeah good question. I considered that, but I actually think MCP servers should be shared between frameworks. I talked to @dsp-ant and plan to make a PR to the MCP repo to make this part of their SDK, so then this import would just be an alias to mcp.client.MCPServer.
stevenheidel
previously approved these changes
Mar 25, 2025
### Summary: 1. Add the MCP dep for python 3.10, since it doesn't support 3.9 and below 2. Create MCPServer, which is the agents SDK representation of an MCP server 3. Create implementations for HTTP-SSE and StdIO servers, directly copying the [MCP SDK example](https://github.com/modelcontextprotocol/python-sdk/blob/main/examples/clients/simple-chatbot/mcp_simple_chatbot/main.py) 4. Add a util to transform MCP tools into Agent SDK tools Note: I added optional caching support to the servers. That way, if you happen to know a server's tools don't change, you can just cache them. ### Test Plan: Checks pass. I added tests at the end of the stack.
rm-openai
added a commit
that referenced
this pull request
Mar 25, 2025
### Summary: This enables users to **use** MCP inside the SDK. 1. You add a list of MCP servers to `Agent`, via `mcp_server=[...]` 2. When an agent runs, we look up its MCP tools and add them to the list of tools. 3. When a tool call occurs, we call the relevant MCP server. Notes: 1. There's some refactoring to make sure we send the full list of tools to the Runner/Model etc. 2. Right now, you could have a locally defined tool that conflicts with an MCP defined tool. I didn't add errors for that, will do in a followup. ### Test Plan: See unit tests. Also has an end to end example next PR. --- [//]: # (BEGIN SAPLING FOOTER) * #324 * #322 * __->__ #321 * #320
rm-openai
added a commit
that referenced
this pull request
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Note: I added optional caching support to the servers. That way, if you happen to know a server's tools don't change, you can just cache them.
Test Plan:
Checks pass. I added tests at the end of the stack.
#324
#322
#321
-> #320
#319