Skip to content

Small fixes for reading the input files correctly and to the OpenAIFi… #1801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 7, 2025

Conversation

robtinn
Copy link
Contributor

@robtinn robtinn commented Apr 30, 2025

Summary

The first of a few PRs I will do to update and extend the content in this cookbook example.

This PR will make some small fixes:

  • attribute style access for self.file_object
  • ensuring the training file is read as binary to avoid errors
  • updating the wait_for_finetuning method so it uses retrieve() instead of refresh() and exits on success, failure or job cancellation.

Motivation

Some of these issues have been picked up in the GitHub issues and it will make the cookbook easier to run without users having to make several fixes.

@robtinn robtinn requested review from emitchell-openai and removed request for emitchell-openai May 6, 2025 15:31
Copy link
Contributor

@MW-OAI MW-OAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top half is fine with these edits

Worth ensuring Qdrant can run properly or remove in full
Worth exploring FT of 4.1-nano to bring it to latest models

@robtinn robtinn merged commit 80251ba into main May 7, 2025
1 check passed
@robtinn robtinn deleted the rtinn/fine-tuned_qa_small_fixes branch May 7, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants