Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.1.2]「HTMLの要素や属性を正しい役割で使用する」のタイトル・内容の見直し #417
[4.1.2]「HTMLの要素や属性を正しい役割で使用する」のタイトル・内容の見直し #417
Changes from 4 commits
7ef7411
430acd6
353ef46
e33befe
657810a
3668060
863594f
4310bcb
88e84ed
13f2862
5a86773
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 31 in src/4/1/2.md
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
textlintのtextlint-rule-ja-no-mixed-periodルールでwarningでちゃう・・
設定ファイル
.textlintrc
を以下のように編集することで、「参考:」で始まる行を許容できるっぽいんですが、ウーン・・表記を変えれば良いけどいい案がパッと浮かばないなう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
例えばですけど。
「詳細は以下の参考資料で確認できる。」みたいな文章的な言い回しにするか、
「### 参考資料」みたいな感じで見出しにしちゃうとかだとどうですかね?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
h3見出しにしました:pray:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
そういえばですが英字?だと左側の文字かけてそうな気がw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
あーそれ気になってたんですよねw
summary要素にtext-indentプロパティが設定されてて、これかなーと思うので別で修正しますね:pray:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#420 にて:pray:
Check warning on line 40 in src/4/1/2.md
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かいところで🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:sugutypo:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
863594f にて 😄
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.