Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: summary要素の先頭文字が見切れている #420

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Conversation

tokimari
Copy link
Contributor

@tokimari tokimari commented Oct 11, 2023

概要

折りたたみ表示のsummary要素の先頭文字が見切れているのを修正しました。

before after
修正前のイメージ 修正後のイメージ
先頭文字が見切れている 先頭文字が全て見えている

関連リンク

#417 (comment)

確認項目

Pull Requestを出す前に確認しましょう。

  • コミットは適切にまとめられているか
  • Pull Requestの概要を適切に書いたか
  • レビュワーの指定をしているか
  • textlintを実行しエラーが出ていないか
  • Accessibility

その他

@reg-suit
Copy link

reg-suit bot commented Oct 11, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 619dff8):

https://ameba-a11y-guidelines--pr420-fix-summary-pil3wuui.web.app

(expires Wed, 18 Oct 2023 07:44:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: b5ed0ee52825c395d695adc443890c0775e604f1

@tokimari
Copy link
Contributor Author

regression testが仕事している:tada:

$ ag summary src/**/*.md
14 matches
3 files contained matches
56 files searched
154509 bytes searched
0.004563 seconds
src/1/1/1.md
19:  <summary>代替テキストとは</summary>
36:  <summary>広告の代替テキストについて</summary>
120:  <summary>親要素にラベルを設定する方法</summary>
131:  <summary>roleをimgにした上で、ラベルを設定する方法</summary>

src/2/3/3.md
24:  <summary>モーションアニメーションとは</summary>
29:  <summary>必要不可欠なアニメーション</summary>

src/4/1/3.md
21:<summary>ステータスメッセージとは</summary>

の3箇所分だけfailしていました:pray:https://storage.googleapis.com/a11y-guidelines/619dff8c389d662e427a1bdbd7bafb4cbf564367/index.html?stat=q1ZKS8zMSU3xLEnNLXbOL80rUbIy1lHKSy1HFjHQUUpJzUktQVUHFC1ILC5GFTQF6i7OyC8qcUktTi7KLCjJzM9TskpLzClOrQUA

@tokimari tokimari merged commit baef521 into master Oct 12, 2023
5 checks passed
@tokimari tokimari deleted the fix/summary branch October 12, 2023 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants