Add test for useHelmet() hook

openameba · May 17, 2019 · 87845ab · 87845ab
1 parent 78d3923
commit 87845ab
Show file tree

Hide file tree

Showing 5 changed files with 4,882 additions and 22 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -13,19 +13,6 @@
     "rules": {
         "react-hooks/rules-of-hooks": "error",
         "react-hooks/exhaustive-deps": "error",
-        "prettier/prettier": [
-            "error",
-            {
-                "printWidth": 80,
-                "tabWidth": 4,
-                "singleQuote": false,
-                "trailingComma": "none",
-                "bracketSpacing": false,
-                "semi": true,
-                "useTabs": false,
-                "parser": "babel",
-                "jsxBracketSameLine": false
-            }
-        ]
+        "prettier/prettier": "error"
     }
 }
diff --git a/.prettierrc.json b/.prettierrc.json
@@ -0,0 +1,11 @@
+{
+    "printWidth": 80,
+    "tabWidth": 4,
+    "singleQuote": false,
+    "trailingComma": "none",
+    "bracketSpacing": false,
+    "semi": true,
+    "useTabs": false,
+    "parser": "babel",
+    "jsxBracketSameLine": false
+}
diff --git a/src/Helmet.js b/src/Helmet.js
@@ -280,7 +280,7 @@ function generateUniqueString() {
     );
 }
 
-function useHelmet(props) {
+function useHelmet(props = {}) {
     const instance = useMemo(() => generateUniqueString(), []);
     const dispatch = useContext(HelmetContext);
     const called = useRef(false);
@@ -291,7 +291,11 @@ function useHelmet(props) {
         }
         prevProps.current = props;
         const {children, ...restProps} = props;
-        let newProps = {...restProps};
+        let newProps = {
+            defer: true,
+            encodeSpecialCharacters: true,
+            ...restProps
+        };
         if (children) {
             newProps = mapChildrenToProps(children, newProps);
         }
@@ -321,11 +325,6 @@ const Helmet = props => {
 
 Helmet.displayName = "Helmet";
 
-Helmet.defaultProps = {
-    defer: true,
-    encodeSpecialCharacters: true
-};
-
 if (process.env.NODE_ENV !== "production") {
     /**
      * @param {Object} base: {"target": "_blank", "href": "http://mysite.com/"}