Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Checkbox, Radio outline with text #1046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

herablog
Copy link
Member

@herablog herablog commented Sep 6, 2024

CheckboxとRadioのテキストあり時のフォーカススタイルの要件が満たせておらず、CSSの変更のみで対応できた(自信はないです)ので修正しました。

Screenshot 2024-09-06 at 6 37 10 PM Screenshot 2024-09-06 at 6 37 02 PM

利用時にスタイルをつけている場合2重で表示される可能性がありますが、致命的な問題ではないと判断しました w/ @yasuda-shin

@herablog herablog requested a review from yasuda-shin September 6, 2024 09:41
@herablog herablog self-assigned this Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Visit the preview URL for this PR (updated for commit af4c12a):

https://ameba-spindle--pr1046-fix-checkbox-outline-ftebclir.web.app

(expires Sun, 06 Oct 2024 09:46:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

Copy link

reg-suit bot commented Sep 6, 2024

✨✨ That's perfect, there is no visual difference! ✨✨

Check out the report here.

Copy link
Contributor

@yasuda-shin yasuda-shin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants