chore(spindle-tokens): export design token with Figma variables #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
herablog
force-pushed
the
chore/style-dictionary-v4
branch
2 times, most recently
from
ef1c7c0 to
afdd2c2
Compare
herablog
changed the title
herablog
commented
Sep 12, 2024
| files: [ | ||
| { | ||
| destination: 'dist/json/spindle-tokens.json', | ||
| format: 'json', | ||
| destination: 'dist/css/spindle-tokens-animation.css', |
There was a problem hiding this comment.
書き出しは今使われている設定に合わせます。(allは作ってないですが)
ref: https://unpkg.com/browse/@openameba/[email protected]/dist/css/
There was a problem hiding this comment.
使ってるのかなぁと形式変わっちゃうしなぁの2点で作ってないですが、作ることもできます〜
herablog
commented
Sep 12, 2024
| @@ -0,0 +1,137 @@ | |||
| { | |||
herablog
commented
Sep 12, 2024
| @@ -0,0 +1,101 @@ | |||
| { | |||
| "Drop Shadow": { | |||
There was a problem hiding this comment.
ShadowはFigmaから書き出すよさが今の所ないので、手動で作ってます。
yasuda-shin
reviewed
Sep 13, 2024
| files: [ | ||
| { | ||
| destination: 'dist/json/spindle-tokens.json', | ||
| format: 'json', | ||
| destination: 'dist/css/spindle-tokens-animation.css', |
| } | ||
|
|
||
| export function transformPrimitiveColor(variables: GetLocalVariablesResponse) { | ||
| const primitiveColorCollections = Object.values( |
There was a problem hiding this comment.
variables.meta.variableCollections のエラーハンドリングあってもいいかなと思ったんですけど。
token配信してエラーになるケース。ないですよね。大丈夫か。
There was a problem hiding this comment.
export -> PRで確認 -> CSSにして配信 というフローなので大丈夫そうですがどうでしょか！
| transformAnimationProperty, | ||
| } from '../lib/animation-transformer'; | ||
|
|
||
| const FIGMA_FILE_KEY = 'st60hCtXaGsXQCnCwNS9Dy'; |
There was a problem hiding this comment.
このキーって見えてて大丈夫なものなんです？
（イマイチわかってない）
There was a problem hiding this comment.
@MasatoHonda 確認済みです！ #1102 でも埋め込んでます〜 (URLの一部です)
herablog
force-pushed
the
chore/style-dictionary-v4
branch
from
c0946e3 to
3c21d90
Compare
yasuda-shin
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
デザイントークンの書き出し元をFigma StylesからFigma Variablesに変更しました。それに伴いトークンの形式をDesign Tokens Community Group specに変更しています。
※ style-dictionary v4で対応してたのでちょうどよかった :js_peace:
大まかな対応は以下の通りです