Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check size with bundlewatch instead of bundlesize #1103

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

herablog
Copy link
Member

@herablog herablog commented Sep 13, 2024

@sasaplus1 調査により bundlesize が node20 にあげられない原因だったので bundlesize に影響を受けたという bundlewatch(Inspired by Siddharth Kshetrapal bundlesize)に変更しました。(設定ファイルがほぼそのまま使えて便利でした)

GitHub Appもありそうですが、そこまで必要ないのでCLIで使ってます。

$ yarn why iltorb
yarn why v1.22.22
[1/4] :thinking_face:  Why do we have the module "iltorb"...?
[2/4] :truck:  Initialising dependency graph...
[3/4] :mag:  Finding dependency...
[4/4] :aerial_tramway:  Calculating file sizes...
=> Found "[email protected]"
info Reasons this module exists
   - "_project_#@openameba#spindle-hooks#bundlesize#brotli-size" depends on it
   - Hoisted from "_project_#@openameba#spindle-hooks#bundlesize#brotli-size#iltorb"
info Disk size without dependencies: "8.7MB"
info Disk size with unique dependencies: "10.64MB"
info Disk size with transitive dependencies: "13.28MB"
info Number of shared dependencies: 48
:sparkles:  Done in 0.84s.

この変更を含んだnode 20あげはこちらでチェックしました。
https://github.com/openameba/spindle/actions/runs/10846854277/job/30100678631

@herablog herablog requested a review from sasaplus1 September 13, 2024 09:51
@herablog herablog self-assigned this Sep 13, 2024
@herablog herablog enabled auto-merge September 13, 2024 09:53
Copy link
Contributor

Visit the preview URL for this PR (updated for commit ac69beb):

https://ameba-spindle-hooks--pr1103-chore-replace-bundle-3ylu6bcu.web.app

(expires Sun, 13 Oct 2024 09:55:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 7dd86a3c25a55dbb81dd4fa259473bf50648140b

Copy link
Contributor

Visit the preview URL for this PR (updated for commit ac69beb):

https://ameba-spindle--pr1103-chore-replace-bundle-wsonm4y0.web.app

(expires Sun, 13 Oct 2024 09:56:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@herablog herablog changed the title chore(spindle-hooks): check size with bundlewatch Check size with bundlewatch instead of bundlesize Sep 13, 2024
Copy link

reg-suit bot commented Sep 13, 2024

reg-suit detected visual differences.

Check this report, and review them.

⚪ New
203
How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

Copy link
Member

@sasaplus1 sasaplus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ローカルでファイルサイズちゃんと取れてて大丈夫そうでした。

@herablog herablog merged commit 6371b24 into main Sep 13, 2024
13 of 14 checks passed
@herablog herablog deleted the chore/replace-bundlesize branch September 13, 2024 10:00
@herablog
Copy link
Member Author

助かりましたー!ありがとうございます!

エンジニアを褒めるネコ:神

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants