feat(spindle-ui): add switch attribute to ToggleSwitch #1114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reg-suit detected visual differences. Check this report, and review them.
How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
|
Visit the preview URL for this PR (updated for commit 489304a): https://ameba-spindle--pr1114-feat-input-switch-gsn3fmis.web.app (expires Fri, 18 Oct 2024 03:57:37 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435 |
herablog
force-pushed
the
feat/input-switch
branch
2 times, most recently
from
f4cc6c8 to
6c46d3e
Compare
herablog
force-pushed
the
feat/input-switch
branch
from
6c46d3e to
57d9156
Compare
herablog
force-pushed
the
feat/input-switch
branch
from
57d9156 to
489304a
Compare
herablog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safariで<input type="checkbox" switch>が対応されたので、switch属性を追加しました。スタイルはSpindle定義のものを使いたいのでそれ以外の変更はないですが、スクリーンショットの通りroleがswitchになるのでより正確になるかなと思います。属性追加に際して互換性が担保されているためサポートしていないブラウザでは何も起こらないはずです。
サポートブラウザが広がりしだいスタイルも対応できたらと思います。
ref: Safari 17.4 supports <input type="checkbox" switch>
Preview: https://ameba-spindle--pr1114-feat-input-switch-gsn3fmis.web.app/?path=/story/form-toggleswitch--toggle-switch
Before
After