Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: set firebase-tools version to deploy #866

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

herablog
Copy link
Member

@herablog herablog commented Dec 12, 2023

Firebase HostingにデプロイできずPRが取り込めないので、取り急ぎデプロイできるようにしました。

本質的にはnodeバージョンを上げるべきですが、変更範囲がFirebase関連以外にもあり、対応にやや時間を要するためfirebase-toolsのバージョンを落として現状のnodeで動作するようにしています。

成功workflow: https://github.com/openameba/spindle/actions/runs/7189444688/job/19580966571

Copy link
Contributor

github-actions bot commented Dec 13, 2023

Visit the preview URL for this PR (updated for commit 020ebdd):

https://ameba-spindle--pr866-ci-firebase-tools-ve-mzbpk0si.web.app

(expires Fri, 12 Jan 2024 01:28:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: e7521619a2dd5c653490c8246e81ec2a5c8f1435

@herablog herablog force-pushed the ci/firebase-tools-version branch from 020ebdd to 8336048 Compare December 13, 2023 01:30
@herablog herablog self-assigned this Dec 13, 2023
@herablog herablog marked this pull request as ready for review December 13, 2023 01:35
@herablog herablog requested review from kc7891 and yossydev December 13, 2023 01:35
Copy link
Member

@yossydev yossydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます!!!:kannsya:
LGTMeow

Copy link
Contributor

@kc7891 kc7891 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@herablog
Copy link
Member Author

Mergeしますので取り込みお願いします!

@herablog herablog merged commit 03e0a68 into main Dec 13, 2023
14 checks passed
@herablog herablog deleted the ci/firebase-tools-version branch December 13, 2023 01:51
@kc7891
Copy link
Contributor

kc7891 commented Dec 13, 2023

ありがとうございます!
取り込んで確認します 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants