Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameba LIFEに関するテキストのルールを修正 #58

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

yasuda-shin
Copy link
Contributor

概要

image

そもそもなのですがAmeba LIFEは半角スペースありが正しかったみたいなので修正しました。
「事業本部」はサービス用語ではないかなと思って追加していませんがご意見募集中です。

@yasuda-shin yasuda-shin requested a review from herablog October 3, 2023 11:37
@yasuda-shin yasuda-shin self-assigned this Oct 3, 2023
@herablog
Copy link
Member

herablog commented Oct 3, 2023

「事業本部」間違えやすいので、入れたい感じはしますね〜区分・名称は変えてもいいかもしれないっす

@yasuda-shin
Copy link
Contributor Author

#59

「事業本部」は上記、別Pull requestに切り出したのでこのPull requestはAmeba LIFEのスコープでいかせていただければとぉ。

Copy link
Member

@herablog herablog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

エンジニアを褒めるネコ:LGTM

@yasuda-shin yasuda-shin merged commit 136b3a9 into main Oct 4, 2023
2 checks passed
@yasuda-shin yasuda-shin deleted the fix/ameba-life-text-rule branch October 4, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants