dbs-cli: several refactor in cmd tool #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
studychao
force-pushed
the
chao/refactor
branch
3 times, most recently
from
0275430 to
93af16d
Compare
justxuewei
reviewed
Nov 15, 2023
README.md
Outdated
| --log-file dbs-cli.log --log-level ERROR \ | ||
| --kernel-path ~/path/to/kernel/vmlinux.bin \ | ||
| --rootfs ~/path/to/rootfs/bionic.rootfs.ext4 \ | ||
| --boot-args "console=ttyS0 console=ttyS1 earlyprintk=ttyS1 tty0 reboot=k debug panic=1 pci=off root=/dev/vda1" \ | ||
| --virnets "[{\"iface_id\":\"eth0\",\"host_dev_name\":\"tap0\",\"num_queues\":2,\"queue_size\":0,\"guest_mac\":\"43:2D:9C:13:71:48\",\"allow_duplicate_mac\":true}]" \ | ||
| create; | ||
| ; |
There was a problem hiding this comment.
done and I remove all redundant ;
README.md
Outdated
| --log-file dbs-cli.log --log-level ERROR \ | ||
| --kernel-path ~/path/to/kernel/vmlinux.bin \ | ||
| --rootfs ~/path/to/rootfs/bionic.rootfs.ext4 \ | ||
| --boot-args "console=ttyS0 console=ttyS1 earlyprintk=ttyS1 tty0 reboot=k debug panic=1 pci=off root=/dev/vda1" \ | ||
| --virblks '[{"drive_id":"testblk","device_type":"RawBlock","path_on_host":"/path/to/test.img","is_root_device":false,"is_read_only":false,"is_direct":false,"no_drop":false,"num_queues":1,"queue_size":1024}]' \ | ||
| create; | ||
| ; |
README.md
Outdated
| @@ -117,9 +117,9 @@ Create hot-plug virtio-net devices via API Server: | |||
|
|
|||
| ``` | |||
| sudo ./dbs-cli \ | |||
| --api-sock-path [socket path] | |||
| --api-sock-path [socket path] update | |||
| --hotplug-virnets "[{\"iface_id\":\"eth0\",\"host_dev_name\":\"tap0\",\"num_queues\":2,\"queue_size\":0,\"guest_mac\":\"43:2D:9C:13:71:48\",\"allow_duplicate_mac\":true}]" \ | |||
| @@ -129,11 +129,13 @@ Create hot-plug virtio-blk devices via API Server: | |||
|
|
|||
| ``` | |||
| sudo ./dbs-cli \ | |||
| --api-sock-path [socket path] | |||
| --api-sock-path [socket path] update | |||
| --hotplug-virblks '[{"drive_id":"testblk","device_type":"RawBlock","path_on_host":"/path/to/test.img","is_root_device":false,"is_read_only":false,"is_direct":false,"no_drop":false,"num_queues":1,"queue_size":1024}]' \ | |||
src/parser/args.rs
Outdated
| #[clap(long, value_parser, default_value = "dbs-cli.log", display_order = 1)] | ||
| pub log_file: String, | ||
|
|
||
| #[clap(long, value_parser, default_value = "Info", display_order = 1)] |
There was a problem hiding this comment.
Is "Debug" a better default value? The reason is that dbs-cli is a debug tool for Dragonball.
README.md
Outdated
| --kernel-path ~/path/to/kernel/vmlinux.bin \ | ||
| --rootfs ~/path/to/rootfs/rootfs.dmg \ | ||
| --boot-args "console=ttyS0 console=ttyS1 earlyprintk=ttyS1 tty0 reboot=k debug panic=1 pci=off root=/dev/vda1" create ; | ||
| --boot-args "console=ttyS0 console=ttyS1 earlyprintk=ttyS1 tty0 reboot=k debug panic=1 pci=off root=/dev/vda1" ; |
There was a problem hiding this comment.
Please remove the space at the end.
README.md
Outdated
| ``` | ||
|
|
||
| Set the log level and log file: | ||
|
|
||
| > The log-level argument is case-insensitive: ErrOR and InFO are valid. | ||
|
|
||
| ```bash | ||
| ./dbs-cli \ | ||
| ./dbs-cli create\ |
README.md
Outdated
| @@ -44,12 +44,12 @@ Create a vsock console (communication with sock file) | |||
| > Otherwise, `dbs-cli` will create a vsock console with a sock file, namely the value of `serial-path`. | |||
|
|
|||
| ``` | |||
| ./dbs-cli \ | |||
| ./dbs-cli create\ | |||
README.md
Outdated
| @@ -60,12 +60,12 @@ Create a virtio-vsock tunnel for Guest-to-Host communication. | |||
| > specified with the `--vsock` parameter. | |||
|
|
|||
| ``` | |||
| ./dbs-cli \ | |||
| ./dbs-cli create\ | |||
README.md
Outdated
| @@ -89,13 +89,13 @@ Create virtio-blk devices. | |||
| > format of JSON. | |||
|
|
|||
| ``` | |||
| ./dbs-cli \ | |||
| ./dbs-cli create\ | |||
1. Add all creation related args under Create command and all update related args under Update command. 2. catagorize different args type to make more sense, like putting all cpu related commands under CpuArgs instead of putting them everything without order. Signed-off-by: Chao Wu <[email protected]>
studychao
force-pushed
the
chao/refactor
branch
from
93af16d to
597ae08
Compare
justxuewei
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add all creation related args under Create command and all update related args under Update command.
catagorize different args type to make more sense, like putting all cpu related commands under CpuArgs instead of putting them everywhere without order.