Support adding vhost-net network devices #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Argument `virnets` receives a JSON string of `NetworkInterfaceConfig`, rather than `VirtioNetDeviceConfigInfo`. It allows user to add any network devices according to item's backend type. Signed-off-by: Xuewei Niu <[email protected]>
justxuewei
force-pushed
the
feat/vhost-net
branch
from
17f0651 to
6a4fb7a
Compare
studychao
reviewed
Nov 23, 2023
src/api_server.rs
Outdated
| for config in configs.iter() { | ||
| self.insert_virnet(config.clone()) | ||
| .context("Insert a virtio-net device to the Dragonball")?; | ||
| .context("Insert a virtio device to the Dragonball")?; |
There was a problem hiding this comment.
The user cannot know that it's net device that went wrong in this error message.
src/vmm_comm_trait.rs
Outdated
| self.handle_request(Request::Sync(VmmAction::InsertNetworkDevice(config))) | ||
| .context("Request to insert a virtio-net device")?; | ||
| .context("Request to insert a virtio device")?; |
- Errors have net device type and name. - Formating the import blocks of "vmm_comm_trait.rs". Signed-off-by: Xuewei Niu <[email protected]>
studychao
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument
virnetsreceives a JSON string ofNetworkInterfaceConfig, rather thanVirtioNetDeviceConfigInfo. It allows user to add any network devices according to item's backend type.