OBS-1724 Add option to give select only access to DB #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmiranda
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
Make sure the "enabling DB read only access" bit is idempotent.
Including our public IP addresses in these inventory files is making me uncomfortable. Not something we need to deal with now, but perhaps in the future. I've created an issue (#72).
|
@jmiranda I was raising a question about these public IPs in the past, and if these should be moved to the vault. I remember the decision was that we don't have to do it right now. I agree this should be tackled as a tech debt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.