-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OBKN-706 Pull out common styling #270
base: develop
Are you sure you want to change the base?
Conversation
This PR is probably just a first part of the component styling cleanup.
with a custom component
I also focused on splitting some components into smaller parts like index.tsx, styles.ts and types.ts files in their directory instead of having everything stored in a single file. |
@drodzewicz please fix two bugs brought up by sonar |
c7962f7
to
dc1373c
Compare
…able and cleanup unused styles
dc1373c
to
2d11a67
Compare
…entLayout components
4ca222c
to
482d7ee
Compare
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
@awalkowiak pr is ready for a review |
@awalkowiak @drodzewicz I don't feel 100% comfortable merging this until we are done with the current release (KN is still testing), but I want to get this in before it becomes a huge hassle to merge. Also can we do a tech huddle on this so I understand what's going? |
@jmiranda this can definitely wait a bit until the next release but will need to be constantly updated. This is a cleanup for the tech debt around duplicated styling. |
No description provided.