Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBKN-706 Pull out common styling #270

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

drodzewicz
Copy link
Collaborator

No description provided.

@drodzewicz drodzewicz self-assigned this Jul 22, 2022
@drodzewicz
Copy link
Collaborator Author

This PR is probably just a first part of the component styling cleanup.
Here I mainly focused on replacing all of the instances of

      <View style={styles.columnItem}>
        <Text style={styles.label}>{title}</Text>
        <Text style={styles.value}>{subText}</Text>
      </View>
      <View style={styles.columnItem}>
        <Text style={styles.label}>{title}</Text>
        <Text style={styles.value}>{subText}</Text>
      </View>

with a custom component

const renderData = [
     { label: 'title1', value: 'value1' }, 
     { label: 'title1', value: 'value1' } 
]
<DetailsTable data={renderData} />

I also focused on splitting some components into smaller parts like index.tsx, styles.ts and types.ts files in their directory instead of having everything stored in a single file.

src/components/Radio/styles.ts Show resolved Hide resolved
src/components/Radio/styles.ts Show resolved Hide resolved
src/components/Radio/styles.ts Show resolved Hide resolved
@awalkowiak
Copy link
Collaborator

@drodzewicz please fix two bugs brought up by sonar

@drodzewicz drodzewicz force-pushed the OBKN-706-pull-out-common-styling branch from c7962f7 to dc1373c Compare July 22, 2022 10:55
@drodzewicz drodzewicz force-pushed the OBKN-706-pull-out-common-styling branch from dc1373c to 2d11a67 Compare July 22, 2022 14:27
@drodzewicz drodzewicz requested a review from awalkowiak July 22, 2022 14:29
@drodzewicz drodzewicz force-pushed the OBKN-706-pull-out-common-styling branch from 4ca222c to 482d7ee Compare July 27, 2022 11:31
@sonarcloud
Copy link

sonarcloud bot commented Jul 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

No Coverage information No Coverage information
3.2% 3.2% Duplication

@drodzewicz
Copy link
Collaborator Author

@awalkowiak pr is ready for a review

@jmiranda
Copy link
Member

jmiranda commented Aug 5, 2022

@awalkowiak @drodzewicz I don't feel 100% comfortable merging this until we are done with the current release (KN is still testing), but I want to get this in before it becomes a huge hassle to merge. Also can we do a tech huddle on this so I understand what's going?

@awalkowiak
Copy link
Collaborator

@jmiranda this can definitely wait a bit until the next release but will need to be constantly updated. This is a cleanup for the tech debt around duplicated styling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants