Skip to content

feat: circuit using entitycore #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 28, 2025
Merged

feat: circuit using entitycore #681

merged 14 commits into from
Aug 28, 2025
+6,476 −422

Conversation

bilalesi
Copy link
Collaborator

@bilalesi bilalesi commented Aug 4, 2025

No description provided.

@bilalesi bilalesi self-assigned this Aug 4, 2025
@bilalesi bilalesi force-pushed the feat/circuit-entitycore-1 branch 2 times, most recently from 5fa879a to b878837 Compare August 4, 2025 14:56
@bilalesi bilalesi changed the title feat: circuit entitycore merge develop feat: circuit using entitycore Aug 4, 2025
@bilalesi bilalesi force-pushed the feat/circuit-entitycore-1 branch 2 times, most recently from 124d6b0 to 5b8e97c Compare August 15, 2025 13:10
bilalesi added 14 commits August 27, 2025 08:01
@bilalesi bilalesi force-pushed the feat/circuit-entitycore-1 branch from 5b8e97c to 8b1f6c9 Compare August 27, 2025 07:57
@bilalesi bilalesi marked this pull request as ready for review August 28, 2025 08:16
@bilalesi bilalesi requested review from tolokoban and pgetta August 28, 2025 08:45
@bilalesi
Copy link
Collaborator Author

bilalesi commented Aug 28, 2025 •
edited
Loading

please, if anyone can test it locally that would be good, just testing that circuit-dev (replace /circuit with /circuit-dev) route in explore are not accessible for staging and production only in dev (NEXT_PUBLIC_DEPLOYMENT_ENV)

tolokoban
tolokoban approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@tolokoban tolokoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested in my local environment.
With NEXT_PUBLIC_DEPLOYMENT_ENV=

  • development: I can get the list of circuits even by replacing circuit with circuit-dev
  • staging: circuit-dev is not accessible.

@bilalesi bilalesi merged commit 07b07f7 into develop Aug 28, 2025
4 checks passed
@bilalesi bilalesi deleted the feat/circuit-entitycore-1 branch August 28, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolokoban tolokoban tolokoban approved these changes

@pgetta pgetta Awaiting requested review from pgetta

@loris-olivier-obi loris-olivier-obi Awaiting requested review from loris-olivier-obi

@g-bar g-bar Awaiting requested review from g-bar

Assignees

@bilalesi bilalesi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilalesi @tolokoban