Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owl-tools#55 #56

Merged
merged 12 commits into from
Jul 9, 2024
Merged

owl-tools#55 #56

merged 12 commits into from
Jul 9, 2024

Conversation

jsjuni
Copy link
Contributor

@jsjuni jsjuni commented Apr 3, 2024

Fixes owl-tools#55

@jsjuni
Copy link
Contributor Author

jsjuni commented Apr 5, 2024

I had to make a small logic modification. The siblingMap() method was used only to generate disjointness axioms, and consequently included only parent classes with more than one child. In the enhanced version it's also used to generate subclass axioms and therefore needs to include that case. I renamed it to childrenMap and moved the logic for checking more than one child to generateClosureAxioms().

Copy link
Member

@melaasar melaasar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melaasar melaasar merged commit af2bb73 into master Jul 9, 2024
2 checks passed
@melaasar melaasar deleted the emit-tree branch July 9, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - vocabulary bundle closure is incomplete
2 participants