Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memorization of last position in video is not per video #289

Open
mic-men opened this issue Jun 6, 2024 · 15 comments · May be fixed by #361
Open

Memorization of last position in video is not per video #289

mic-men opened this issue Jun 6, 2024 · 15 comments · May be fixed by #361
Assignees
@chfsx @ferishili
Labels
bug Something isn't working ILIAS 7 Issue appears or may only appear on ILIAS 7. ILIAS 8 Issue appears or may only appear on ILIAS 8.

Comments

@mic-men
Copy link
Contributor

mic-men commented Jun 6, 2024

Describe the bug
When leaving the Paella Player in the middle of a video, the last position is remembered. Unfortunately this position is not remembered per video, i.e. when playing another video afterwards it starts from the remembered position of the last one.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Play' for a video
  2. The player with the thumbnail is visible. Now click the Play button.
  3. Play some time, pause the video, remember the time stamp the video has stopped.
  4. Leave video and open another one for playing.
  5. The player with the thumbnail is visible. Now click the Play button.
  6. The new video starts from the time position the previous one has been left.

Expected behavior
A new video should play right from the start resp. the position I left exactly this video the last time.

Environment (please complete the following information):

  • ILIAS version: 7.30
  • PHP version: PHP 7.4
  • Plugin version: 7.0.3 (May 2024)
  • Opencast version: 14.6.
  • Browser: Firefox, Chromium

Note
Until there is a solution a certain flag in the config.json of the player should be set to false. Unfortunately I do not know which one, please someone else add this info!
@mic-men mic-men added the bug Something isn't working label Jun 6, 2024
@mic-men
Copy link
Contributor Author

mic-men commented Jun 7, 2024

In order to disable this buggy feature, set

"restoreLastTime": {
"enabled": false,

in config.json
See here.

@dagraf dagraf added Priority: Medium Needs to be fixed/taken care of in the next few month ILIAS 8 Issue appears or may only appear on ILIAS 8. ILIAS 7 Issue appears or may only appear on ILIAS 7. labels Jun 12, 2024
@dagraf
Copy link

dagraf commented Jun 12, 2024

@chfsx Is this a bug you would fix or should we ask @ferishili to do so, since it concerns the Paella player?

@dagraf dagraf added Priority: High Needs to be fixed/taken care of asap and removed Priority: Medium Needs to be fixed/taken care of in the next few month labels Jun 12, 2024
@dagraf dagraf mentioned this issue Jun 12, 2024
Closed
@ferishili
Copy link
Contributor

I will take care of it

ferishili added a commit to elan-ev/ilias-opencast-plugin that referenced this issue Jun 13, 2024
@ferishili
paella improvements
ceed88c 
fixes opencast-ilias#289,
fixes opencast-ilias#292,
fixes opencast-ilias#293,
fixes opencast-ilias#294
@ferishili ferishili mentioned this issue Jun 13, 2024
Merged
ferishili added a commit to elan-ev/ilias-opencast-plugin that referenced this issue Jun 13, 2024
@ferishili
paella improvements
e13232e 
refs opencast-ilias#289,
refs opencast-ilias#292,
refs opencast-ilias#293,
refs opencast-ilias#294
@ferishili ferishili mentioned this issue Jun 13, 2024
Merged
@dagraf
Copy link

dagraf commented Jun 13, 2024

After pulling #295 (for Release 8), the bug no longer exists. I therefore close this issue.

@mic-men Can you please test the PR #296 for Release 7? Thx!

@dagraf dagraf closed this as completed Jun 13, 2024
okaufman added a commit to okaufman/OpenCast that referenced this issue Jun 14, 2024
@okaufman
Merge branch 'release_8' into ilias8_pr277
444bb68 
* release_8:
  [RELEASE] new Version v8.0.7
  [RELEASE] new Version v8.0.6
  install paella-user-tracking v1.42.4
  upgrade opencast-api lib to v1.7 fixes opencast-ilias#298
  paella improvements fixes opencast-ilias#289, fixes opencast-ilias#292, fixes opencast-ilias#293, fixes opencast-ilias#294
  improve livestream config, refs opencast-ilias#286
  [FIX] correct supports_cli variable (did support cli setup anyway)
  [RELEASE] new Version v8.0.5
  [FIX] compatibility issue with EULA section in form
  [FIX] removed double strict-types declarations
  [FIX] make code compliant to the ILIAS 7 version
@mwizgall
Copy link

After pulling #295 (for Release 8), the bug no longer exists. I therefore close this issue.

@mic-men Can you please test the PR #296 for Release 7? Thx!

After pulling #295 (for Release 8), the bug no longer exists. I therefore close this issue.

@mic-men Can you please test the PR #296 for Release 7? Thx!

@dagraf Michael has updated the plugin recently and I tested it afterwards. The issue still exists for ILIAS v7.30.1.

@ferishili
Copy link
Contributor

Make sure that your browser cache is clear

@mwizgall
Copy link

@ferishili If I compare two different Videos the problem still exists.

  1. Video 1 starts at 00:00.
  2. Video 2 starts at the point Video 1 ended.
  3. I clear the browser cache
  4. The first Video I open (Video 1 e.g. ), starts at 00:00 as it should.
  5. Unfortunately Video 2 starts at the position I left Video 1 in step 4.

@ferishili
Copy link
Contributor

We need to look deeper into this problem, it appears that disabling the config restoreLastTime is not enough!

@reiferschris
Copy link
Contributor

Hey @mwizgall could you please check the contents of your config.json after clearing the cache in your browsers dev-tools? They should appear in the network tab where you can see the response and the contents of that file

@mwizgall
Copy link

Hey @reiferschris,

thank's for your help.
Unfortunately I couldn't find the requested information.
I don't have admin access on our system, so I just have the information from Michael, that the plugin has been updated.

The network-tab in Google and Firefox (After clearing the cache and accessing ILIAS + Paella player twice) doesn't contain the communication with the 'config.json' (Screenshot 1/2).
In the search for the debugger I found the config.json (Screenshot 3/4), but I dont think that the information is helpful.

DevTools
DevTools_Firefox
Config js
Network-Tab

Could you give me a more detailed advise, how I can find the neccessary information?

@opencast-ilias opencast-ilias deleted a comment from michaellenhart Jul 8, 2024
@reiferschris
Copy link
Contributor

Hi @mwizgall
try this please:

  1. Open a video in a new tab
  2. Open the dev tools, network tab
  3. search for the check box "disable cache" or something like that (both firefox and chrome have this option)
  4. reload the page, ideally delete the history in the dev tools before that to see only the traffic after the reload.

okaufman added a commit to ilub-unibe-ch/OpenCast that referenced this issue Aug 5, 2024
@okaufman
Merge branch 'release_8' into ilias8
a4b5d8f 
* release_8:
  [RELEASE] Version v8.1.1
  [FIX] bad merge conflict leads to error in StandardPlayerDataBuilder opencast-ilias#324
  [RELEASE] Version v8.1.0
  [Release 8] OCT Text feature opencast-ilias#290
  [Release 8] Upload Thumbnail (Preview) opencast-ilias#305
  [Release 8] Upload Subtitles opencast-ilias#277
  [Release 8] New Right management opencast-ilias#301
  [RELEASE] new Version v8.0.7
  [RELEASE] new Version v8.0.6
  install paella-user-tracking v1.42.4
  upgrade opencast-api lib to v1.7 fixes opencast-ilias#298
  paella improvements fixes opencast-ilias#289, fixes opencast-ilias#292, fixes opencast-ilias#293, fixes opencast-ilias#294
  improve livestream config, refs opencast-ilias#286
  [FIX] correct supports_cli variable (did support cli setup anyway)
  [RELEASE] new Version v8.0.5
  [FIX] compatibility issue with EULA section in form
  [FIX] removed double strict-types declarations
  [FIX] make code compliant to the ILIAS 7 version
@snoesberger
Copy link

Have a look at the following comment: polimediaupv/paella-core#367 (comment)
It seems that the plugin does not correctly implement the getVideoId function in the initialisation parameters, which is needed to store the last video position per event. @ferishili can you please have a look at this?

@mic-men
Copy link
Contributor Author

mic-men commented Oct 18, 2024

With the info @snoesberger found we should try to enable the feature.

@mic-men mic-men reopened this Oct 18, 2024
@mic-men mic-men removed the Priority: High Needs to be fixed/taken care of asap label Oct 18, 2024
@ferishili
Copy link
Contributor

Hi, good that you reopened this, I am ready to start the fix as soon as I get a go by @snoesberger or @dagraf

@dagraf
Copy link

dagraf commented Oct 21, 2024

@ferishili: You have our 'Go'. Thank your for looking into it.

@ferishili ferishili linked a pull request Oct 21, 2024 that will close this issue
Open
ferishili added a commit to elan-ev/ilias-opencast-plugin that referenced this issue Oct 21, 2024
@ferishili
paella player custom get video id function, refs opencast-ilias#289
c6da314
@ferishili ferishili mentioned this issue Oct 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chfsx chfsx

@ferishili ferishili

Labels
bug Something isn't working ILIAS 7 Issue appears or may only appear on ILIAS 7. ILIAS 8 Issue appears or may only appear on ILIAS 8.
Projects
Opencast & Opencast PageComponent
Status: In review
Milestone
No milestone
7 participants
@chfsx @dagraf @reiferschris @ferishili @mic-men @snoesberger @mwizgall