Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release 8] Studio group #340

Merged
merged 2 commits into from
Dec 17, 2024
Merged

[Release 8] Studio group #340

merged 2 commits into from
Dec 17, 2024

Conversation

ferishili
Copy link
Contributor

This PR fixes #339

What is new

  • A new group configuration right below ILIAS Producers is introduced named "Opencast Studio"
  • The addCurrentUserToProducer method is now optimized to support different groups and it is renamed to addCurrentUserToGroup
  • Clicking on Opencast Studio, system will add users to producers group if they have Edit Video perm, otherwise, they will be added to studio group!

This PR might get updated...

@ferishili ferishili added enhancement New feature or request ILIAS 8 Issue appears or may only appear on ILIAS 8. labels Aug 9, 2024
@ferishili ferishili requested a review from dagraf August 9, 2024 10:30
@ferishili ferishili self-assigned this Aug 9, 2024
@ferishili ferishili requested a review from chfsx August 23, 2024 09:08
chfsx
chfsx requested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@chfsx chfsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ferishili and thanks a lot for the PR! please have a look at the inline comments and questions.

@ferishili ferishili requested a review from chfsx August 23, 2024 12:37
@ferishili
Copy link
Contributor Author

Hi @chfsx, I've answered all the questions and comments. Please take a look and let me know if a VC would help to clarify this PR! Thanks

@ferishili ferishili added the Ready to merge This PR is tested and ready to be reviewed and merged. label Oct 18, 2024
@ferishili
Copy link
Contributor Author

Hi @chfsx,
Please let me know if you still have questions or something is still missing here.
Thanks

@dagraf
Copy link

dagraf commented Oct 21, 2024

We did not yet have time to test this PR properly. Our goal is to test it in the next 2-3 weeks.

@dagraf dagraf removed the Ready to merge This PR is tested and ready to be reviewed and merged. label Nov 18, 2024
@ferishili
Copy link
Contributor Author

Hi @dagraf
What is the status on this?

@dagraf
Copy link

dagraf commented Nov 28, 2024

I passed testing to a colleague here since I do not have time to test it. I will get back to you as soon as possible.

@snoesberger
Copy link

snoesberger commented Dec 3, 2024 •
edited
Loading

This doesn't work as expected yet. If I am logged in to ILIAS with a user who doesn't have studio rights and I click on the studio button, they don't get the studio rights assigned. Instead, they are directly redirected to the Opencast Studio and Opencast is responding with the answer 403 forbidden.

@snoesberger
Copy link

This doesn't work as expected yet. If I am logged in to ILIAS with a user who doesn't have studio rights and I click on the studio button, they don't get the studio rights assigned. Instead, they are directly redirected to the Opencast Studio and Opencast is responding with the answer 403 forbidden.

@ferishili forget my last comment. The studio group assignment works as expected. It was a misconfiguration on our end. The studio group was renamed in Opencast, but not the actual name of the group (like ROLE_GROUP_OPENCAST_STUDIO), only the display name. So the wrong studio group name was configured in ILIAS.
We will continue our tests.

@ferishili
Copy link
Contributor Author

Hi @snoesberger,
Thank you for your correction; I look forward to your test results.
BR

@snoesberger snoesberger mentioned this pull request Dec 10, 2024
Open
@snoesberger
Copy link

Our tests of this PR were successful. As mentioned above, the assignment of the "studio" role works as expected for course members with "record" rights. Also users with "video edit" rights will be assigned the "producer" role in Opencast.

I have opened a new issue with some suggestions (which are not directly related to this issue) on how to treat OC-Studio uploads more like other video uploads in ILIAS: #382

@dagraf
Copy link

dagraf commented Dec 17, 2024

We did some further testings and everything works as expected. Therefore and @chfsx: Can you please review this PR and merge it if everything is fine or comment it if otherwise. Thx!

@ferishili
Copy link
Contributor Author

Hi @chfsx, I've answered all the questions and comments. Please take a look and let me know if a VC would help to clarify this PR! Thanks

Just a minor reminder, this has already been reviewed, and I have resolved the changes/questions. Again, if there is something unclear, I would suggest that we discuss it in a VC Meeting.

@chfsx
Copy link
Contributor

chfsx commented Dec 17, 2024

@ferishili thanks for the reminder, look everything good to me and teh new release is already prepared, I just wait for #366 which maybe can be merged as well

chfsx added a commit that referenced this pull request Dec 17, 2024
@chfsx
[FEATURE] Studio Group, see PR #340
2d62afc 
commit 03505c1
Author: ferishili <[email protected]>
Date:   Fri Aug 23 11:04:55 2024 +0200

    according to request

commit 50da049
Author: ferishili <[email protected]>
Date:   Fri Aug 9 12:25:38 2024 +0200

    introducing studio group
    fixes #339
@chfsx chfsx merged commit faf830a into opencast-ilias:release_8 Dec 17, 2024
@chfsx
Copy link
Contributor

chfsx commented Dec 17, 2024

This PR has been merged locally and is part of https://github.com/opencast-ilias/OpenCast/releases/tag/v8.3.0

okaufman added a commit to ilub-unibe-ch/OpenCast that referenced this pull request Jan 10, 2025
@okaufman
Merge branch 'release_8' into ilias8-update-2025
628d366 
* release_8:
  [RELEASE] Version v8.3.0
  [FIX] Paella player playbar optimisations, see PR opencast-ilias#380
  [FIX] Response from OC-16 changed, fixes opencast-ilias#374, see PR opencast-ilias#375
  [FEATURE] Studio Group, see PR opencast-ilias#340
  [FIX] small issue with non existing suffixes
  fixes opencast-ilias#371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfsx chfsx chfsx approved these changes

@dagraf dagraf Awaiting requested review from dagraf

Assignees

@ferishili ferishili

Labels
enhancement New feature or request ILIAS 8 Issue appears or may only appear on ILIAS 8.
Projects
Opencast & Opencast PageComponent
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Studio Group
4 participants
@ferishili @dagraf @snoesberger @chfsx