Update validate_forecast.py #252
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you update tests too |
| """ | ||
|
|
||
| # Make validation optional using an environment variable | ||
| strict_validation = os.getenv("STRICT_VALIDATION", "False").lower() == "true" |
There was a problem hiding this comment.
could this be FORECAST_VALIDATION_RAISE_ERROR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Made validation optional
Introduced STRICT_VALIDATION environment variable to control whether failures stop execution or just log errors.
Changed return type from None to bool
Instead of raising exceptions, the function returns False on failure, allowing other models to continue.
Replaced hard failures with logging
Errors are now logged instead of stopping execution unless strict validation is enabled.
Ensures all models continue logging even if one fails
By returning False, the function allows other models to log their forecasts without interruption.
Fixes #248
Checklist: