-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: CreateNewUserComponent from class to functional. #7733
Conversation
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
Your environment is deployed to https://refactorclass-components-to-functio.opencrvs.dev |
Thanks for the great work @Eezi ! Just need a ts type definition fix to pass failing tests |
e70ae0c
to
21862bb
Compare
@@ -1,123 +0,0 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naftis @Zangetsu101 we removed this module altogether. If we understood correctly, it was here to control some animation we used to have (?) for opening the event selection / form. I tested this on QA both on mobile and desktop view but couldn't see an animation which led me to believe it wasn't working in the first place. The old code was also not the best and Tomi's tests were failing after turning it into a function component.
Reckon this is fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup agreed the animation was broken for quite a while I think
No description provided.