Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: CreateNewUserComponent from class to functional. #7733

Merged
merged 18 commits into from
Nov 26, 2024

Conversation

Eezi
Copy link
Collaborator

@Eezi Eezi commented Oct 5, 2024

No description provided.

Copy link

github-actions bot commented Oct 5, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://refactorclass-components-to-functio.opencrvs.dev

@tahmidrahman-dsi tahmidrahman-dsi deployed to refactorclass-components-to-functio November 7, 2024 12:14 — with GitHub Actions Active
@tahmidrahman-dsi
Copy link
Collaborator

Thanks for the great work @Eezi ! Just need a ts type definition fix to pass failing tests
packages/client/src/views/SysAdmin/Team/user/userCreation/CreateNewUser.tsx

@Eezi Eezi force-pushed the refactor/class-components-to-functional branch from e70ae0c to 21862bb Compare November 18, 2024 16:24
@@ -1,123 +0,0 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naftis @Zangetsu101 we removed this module altogether. If we understood correctly, it was here to control some animation we used to have (?) for opening the event selection / form. I tested this on QA both on mobile and desktop view but couldn't see an animation which led me to believe it wasn't working in the first place. The old code was also not the best and Tomi's tests were failing after turning it into a function component.

Reckon this is fine?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup agreed the animation was broken for quite a while I think

@Eezi Eezi merged commit a546db5 into develop Nov 26, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants