Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message when date of death is before date of birth #8373

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

oni-on1003
Copy link

No description provided.

@naftis naftis added 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 🔧Waiting for fixes labels Jan 22, 2025
@naftis
Copy link
Member

naftis commented Jan 22, 2025

Could you check why the one unit test fails, please?

 ❯ src/utils/validate.test.ts  (100 tests | 1 failed) 108ms
   ❯ src/utils/validate.test.ts > validate > isValidDeathOccrenceDate. Checks a given date of death is valid > should error when input a date before DOB of deceased
     → expected undefined to deeply equal { message: { …(3) } }

@oni-on1003
Copy link
Author

Hello @naftis , I've fixed the unit test for this pull request.

@naftis naftis changed the title Fixed no error message when date of death is before date of birth fix: add error message when date of death is before date of birth Jan 24, 2025
@naftis
Copy link
Member

naftis commented Jan 24, 2025

LGTM as that validator is described as

 "validations.isDateNotBeforeBirth": "Date must be after deceased birth date",

Will need to see how we can run the end-to-end tests but should be good to merge

Copy link

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale The pr is inactive label Feb 14, 2025
@github-actions github-actions bot removed the Stale The pr is inactive label Feb 15, 2025
Copy link

github-actions bot commented Mar 8, 2025

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale The pr is inactive label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it Stale The pr is inactive
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants