Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: webhooks microservice not starting in staging or production #8605

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

euanmillar
Copy link
Collaborator

@euanmillar euanmillar commented Feb 7, 2025

QA_ENV: default doesnt exist and as it is undefined in staging or production docker compose, the webhooks container doesnt start.

Copy link

github-actions bot commented Feb 7, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@euanmillar euanmillar changed the title fix: webhooks microservice not starting as no default value is sent i… fix: webhooks microservice not starting in staging or production Feb 7, 2025
@euanmillar euanmillar requested a review from naftis February 7, 2025 11:45
Copy link
Member

@naftis naftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the same configuration is applied in user-mgnt.

Copy link

This PR has been marked with label stale Since it has been inactive for 20 days. It will automatically be closed in 10 days if no further activity occurs.

@github-actions github-actions bot added the Stale The pr is inactive label Feb 28, 2025
@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Feb 28, 2025
@github-actions github-actions bot temporarily deployed to webhooks-not-starting February 28, 2025 08:19 Inactive
@naftis naftis deployed to webhooks-not-starting February 28, 2025 08:19 — with GitHub Actions Active
@github-actions github-actions bot removed the Stale The pr is inactive label Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 💅 Waiting For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants