Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disabled color in text input and dropdowns #8775

Merged
merged 9 commits into from
Mar 7, 2025
Merged

fix: disabled color in text input and dropdowns #8775

merged 9 commits into from
Mar 7, 2025

Conversation

tahmidrahman-dsi
Copy link
Collaborator

@tahmidrahman-dsi tahmidrahman-dsi commented Feb 25, 2025 •
edited
Loading

image

@tahmidrahman-dsi tahmidrahman-dsi self-assigned this Feb 25, 2025
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
naftis
naftis approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@naftis naftis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, JPF can double-check the style. Accessibility-wise the contrast between white and dark grey looks fine

@tahmidrahman-dsi
Copy link
Collaborator Author

@jpye-finch I have updated the disabled background color of the dropdowns could you please have a look?

@naftis naftis merged commit eb0702c into develop Mar 7, 2025
42 checks passed
@naftis naftis deleted the fix/textfield-disabled-color branch March 7, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

@jpye-finch jpye-finch Awaiting requested review from jpye-finch

Assignees

@tahmidrahman-dsi tahmidrahman-dsi

Labels
💅 Waiting For Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahmidrahman-dsi @naftis