Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new menu icons #8844

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: new menu icons #8844

wants to merge 6 commits into from

Conversation

jpye-finch
Copy link
Collaborator

  • Updates Workqueue icons
  • Moves Outbox to the top
  • Aligns icon size to design
image

@jpye-finch jpye-finch requested a review from naftis March 4, 2025 11:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2025

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis changed the title updates menu icons feat: new menu icons Mar 5, 2025
@naftis
Copy link
Member

naftis commented Mar 5, 2025

Deploying and testing this on Collab

@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Mar 5, 2025
@github-actions github-actions bot temporarily deployed to menu-worqueue-icons March 5, 2025 11:57 Inactive
@naftis naftis temporarily deployed to menu-worqueue-icons March 5, 2025 11:57 — with GitHub Actions Inactive
@naftis naftis temporarily deployed to menu-worqueue-icons March 6, 2025 13:55 — with GitHub Actions Inactive
@naftis
Copy link
Member

naftis commented Mar 6, 2025

This is fine to merge whenever the E2E passes

@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://menu-worqueue-icons.opencrvs.dev

@naftis naftis deployed to menu-worqueue-icons March 6, 2025 19:20 — with GitHub Actions Active
@Zangetsu101
Copy link
Collaborator

Let's hold off on merging it until we decide which version this will be going into

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naftis naftis naftis approved these changes

Assignees
No one assigned
Labels
✋ On Hold 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jpye-finch @naftis @ocrvs-bot @Zangetsu101