fix bug in old datefield, add leading zeros to new date field mm and dd #8880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cibelius
added
the
🚀 Ready to deploy
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
cibelius
commented
Mar 7, 2025
| @@ -107,9 +107,6 @@ export const DateField = ({ | |||
| const updatedValue = { ...date, [segmentType]: val } | |||
| setDate(updatedValue) | |||
|
|
|||
| if (yyyy === '' && mm === '' && dd === '') { | |||
There was a problem hiding this comment.
This was causing a bug on both V1 and V2: when the user e.g. selects 'day' field, then presses backspace, and tries to enter a character, it will not register the first inputted character, only the second one.
1 task
rikukissa
approved these changes
Mar 7, 2025
|
Your environment is deployed to https://ocrvs-8830-b.opencrvs.dev |
cibelius
removed
the
🚀 Ready to deploy
|
E2e tests passed on rerun here: https://github.com/opencrvs/e2e/actions/runs/13718077049/job/38368403993 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add leading zeroes to month and date field if missing. Also fix bug on V1 and V2 input fields, see comment below.
Screen.Recording.2025-03-07.at.11.35.33.mov