feat: add the ability to configure artifact download link expiry #670
Conversation
|
A new image has been built to help with testing out this PR: To use this image run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines-operator.git
cd data-science-pipelines-operator/
git fetch origin pull/670/head
git checkout -b pullrequest 8a74a7b680e73bd431f9f18dfe12ae540ab26524
oc new-project opendatahub
make deploy IMG="quay.io/opendatahub/data-science-pipelines-operator:pr-670"More instructions here on how to deploy and test a Data Science Pipelines Application. |
HumairAK
changed the title
|
Change to PR detected. A new PR build was completed. |
HumairAK
requested review from
gregsheremeta and
hbelmiro
and removed request for
VaniHaripriya
| @@ -7,6 +7,9 @@ spec: | |||
| apiServer: | |||
| enableSamplePipeline: true | |||
| objectStorage: | |||
| # Need to enable this for artifact download links to work | |||
There was a problem hiding this comment.
if this is the case, should we make the objStore route enabled by default? (outside scope of this ticket, but if so we should open a ticket to track/follow up on)
There was a problem hiding this comment.
I don't have a strong opinion on this, this field itself is misplaced (it should be under minio), it only applies to minio which is a dev feature, so I don't think it matters that much.
|
/approve but also /hold since I believe this needs to go in around the same time as opendatahub-io/data-science-pipelines#62 also giving @HumairAK a chance to see above non-blocking comment, so allowing for a self-unhold |
|
/hold need to firm up the API in opendatahub-io/data-science-pipelines#62 (I'm not sure all the references to |
|
can you change the commit message and the PR title?
(the artifacts aren't expired! just their links ;) ) |
HumairAK
changed the title
Signed-off-by: Humair Khan <[email protected]>
|
Change to PR detected. A new PR build was completed. |
|
/unhold |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gmfrasca, gregsheremeta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The issue resolved by this Pull Request:
Part of https://issues.redhat.com/browse/RHOAIENG-8225
Depends on: opendatahub-io/data-science-pipelines#62
Description of your changes:
This allows a user to configure the expiry time (in seconds) of an artifact download link via the DSPA. Default is 15 seconds.
Testing instructions
.spec.apiServer.artifactSignedURLExpirySecondsset to some value integer.SIGNED_URL_EXPIRY_TIME_SECONDSChecklist