Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return items in _get_render_metadata without validate prereq_met #36244

Open
wants to merge 1 commit into
base: open-release/sumac.master
Choose a base branch
from

Conversation

jignaciopm
Copy link
Contributor

Description

This PR finds a solution to the problem reported in openedx/frontend-app-learning#1546
The endpoint {{domain}}/api/courseware/sequence/{{sequenceId}} was not returning the units (items) when the section (sequence) had a prerequisite.

Before:
391659904-65c09750-21c9-47d2-b4db-ad37ee1c0ac3.webm

After:
https://github.com/user-attachments/assets/c0864e2d-2ab0-4aa0-bbac-c94f31c35ba5

Supporting information

openedx/frontend-app-learning#1546

Testing instructions

  1. Configuring a subsection as a prerequisite
  2. Making that subsection the prerequisite of another subsection
  3. Go to the prerequisite subsection and navigate to the gated subsection
  4. If I try to go to the previous unit right before the gated subsection, the sequence buttons works
  5. If from the sidebar I try entering one of the units in the gated subsection, and the previous button works

@openedx-webhooks
Copy link

Thanks for the pull request, @jignaciopm!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 11, 2025
@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

[Test failure] <TC_AUTHOR_74>: Navigation in Gated Units
3 participants