Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding a new plugin for the enterprise modal on dashboard (take 2) #582

Merged
merged 8 commits into from
Mar 11, 2025

Conversation

kiram15
Copy link
Contributor

@kiram15 kiram15 commented Mar 10, 2025

Verizon requested that the modal that attempts to direct learners to the enterprise dashboard have to be either accepted or dismissed instead of being able to click out of it.

This is part of 3 different PRs that extract the enterprise modal into a plugin.

https://github.com/edx/edx-internal/pull/12452
https://github.com/edx/frontend-plugin-learner-dashboard/pull/73

Jira Ticket - ENT-9853

@kiram15 kiram15 requested a review from a team as a code owner March 10, 2025 21:44
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.44%. Comparing base (dd4f61e) to head (40ed336).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   97.36%   97.44%   +0.08%     
==========================================
  Files         155      152       -3     
  Lines        1365     1330      -35     
  Branches      228      225       -3     
==========================================
- Hits         1329     1296      -33     
+ Misses         34       33       -1     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jsnwesson jsnwesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsnwesson jsnwesson merged commit 3c1b749 into openedx:master Mar 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants